feat: support locale formatting using d3 locale #6119
+104
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Nov 21, 2024
| "minus": { "type": "string", "description": "Optional minus sign (defaults to \"−\")." }, | ||
| "nan": { "type": "string", "description": "Optional value for not-a-number (defaults to \"NaN\")." } | ||
| }, | ||
| "required": ["decimal", "thousands", "grouping", "currency"] |
There was a problem hiding this comment.
I don't think these should all be required. Shouldn't we be able to provide a subset?
| import { format as d3format } from "d3-format"; | ||
| import { | ||
| format as d3format, | ||
| formatLocale, |
There was a problem hiding this comment.
Nit: formatLocale as d3FormatLocale for symmetry with the line above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate
format_d3_localein the UI. This enables support for all currencies, grouping, thousands string, decimal string etc.Usage details here
https://d3js.org/d3-format#formatLocale