Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileCallback should report filename with path #46

Closed
neolib opened this issue Feb 2, 2021 · 2 comments
Closed

FileCallback should report filename with path #46

neolib opened this issue Feb 2, 2021 · 2 comments
Assignees
Milestone

Comments

@neolib
Copy link

neolib commented Feb 2, 2021

I am a new user of this library, hope I am not making fundamental misunderstanding of the lib.

I found that FileCallback only reports bare filename without path information in archive.

Can you make the callback report full path? Full path can be:

  • Full path of the extracted file on disk
  • Relative path as it appears in archive file

It's up to you to decide which is appropriate.

@rikyoz rikyoz self-assigned this Feb 3, 2021
@rikyoz rikyoz added this to the v4.0 milestone Feb 3, 2021
@rikyoz
Copy link
Owner

rikyoz commented Feb 3, 2021

Hi, and thank you for using bit7z!

Can you make the callback report full path? Full path can be:

  • Full path of the extracted file on disk
  • Relative path as it appears in archive file

It's up to you to decide which is appropriate.

I think it's an excellent idea!
Probably I'll make it report the relative path in the archive.
I was already thinking of changing the FileCallback to provide more information about the current file being processed (e.g., its size).
I'll evaluate what to do and implement it for the next major release (v4.0).

I'm currently working on a significant refactoring of the library's internal code, which I don't know how long it will take me (I'm working on it in the spare time).
So I don't have a precise deadline, but I hope to release it as soon as possible.
Thank you again!

rikyoz added a commit that referenced this issue Aug 8, 2021
rikyoz added a commit that referenced this issue Sep 2, 2021
rikyoz added a commit that referenced this issue Sep 4, 2021
@rikyoz
Copy link
Owner

rikyoz commented Oct 1, 2023

Implemented in v4.0.0.

@rikyoz rikyoz closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants