Feat/turborepo #14
Merged
Feat/turborepo #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that the features cover 95% of all browsers.
This change configurates next.js to run with turborepo. Second, it configures eslint to work with jest and storybook, as well as adding good rules to keep code consistent across the repository. It also adds some stylelint and postcss configuration. BREAKING CHANGE: CI scripts will not work. CI and Vercel need to be configured to run with the new code.
This change adds a lighthouse.yml file which checks lighthouse statistics of the vercel preview URL to give useful stats on PRs.
This change adds issue templates for bug reports and feature requests.
This change adds groups for storybook and testing dependencies.
Analyzes security health of the repository and helps with security best practices.
Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks.
I don't know if there is a way to run many tests asynchronously before finally running the release action - but for now I will just have it be manual. I also just don't want to release a millino versions (hyperbolic) for small changes.
CodeQL is a tool for open source projects, or private ones witha license, to analyze code for vulnerabilities based on their own engine.
Going off of the repository on nodejs.org, I decided that their setup would probably be best given that I'm using a similar (but not exactly the same) configuration.
Checks that dependencies are scanned for known vulnerable versions of packages.
This change takes full advantage of turborepo caches to perform faster linting and testing.
Nodejs.org has a really good workflow where they run CI tasks on PRs only when a label is applied. This is really useful when you have WIP PRs that aren't quite done yet, or when you need to correct changes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
rikhall1515BOT
approved these changes
Apr 12, 2024
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does the following:
1. Configures next.js to run with turborepo
2. Moves dependencies around from devDeps to dependencies
in order to optimize build times through
pnpm i -P.3. Adds more github actions and reconfigures previous ones so
that they work with turborepo
4. Adds Storybook and Jest for testing
5. Reconfiguring package.json scripts to work with turborepo
6. Add Issue templates
7. Add Codeowners file
8. Add pre-commit-config
9. Change dependabot to include storybook and Jest groups
Validation
I ran the scripts in the checklist and it worked as it should locally.
Related Issues
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.