Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on Python 3.11.9 and 3.12.3 #138

Closed
rikardg opened this issue Apr 14, 2024 · 0 comments · Fixed by #141
Closed

Tests fail on Python 3.11.9 and 3.12.3 #138

rikardg opened this issue Apr 14, 2024 · 0 comments · Fixed by #141
Assignees
@rikardg

Comments

@rikardg
Copy link
Owner

rikardg commented Apr 14, 2024

The argcomplete API changes in Python 3.11.9 and 3.12.3 causes problems for argcomplete. This in turn makes the completion tests here fail.

Related issues:
rikardg added a commit that referenced this issue Apr 14, 2024
@rikardg
Lock Python patch versions to 3.11.8 and 3.12.2
b92fa65 
Changes to argparse in Python 3.11.9 and 3.12.3 (as well as 3.13.0a5)
causes problems for argcomplete. This causes the Bygg completion
functionality to not work and the relevant tests to fail.

For now, lock the Python versions to 3.11.8 and 3.12.2 in the code
quality workflow, for Nox and in .tool-versions.

Workaround for #138.
@rikardg rikardg mentioned this issue Apr 14, 2024
Merged
rikardg added a commit that referenced this issue Apr 14, 2024
@rikardg
Lock Python patch versions to 3.11.8 and 3.12.2
092fb7d 
Changes to argparse in Python 3.11.9 and 3.12.3 (as well as 3.13.0a5)
causes problems for argcomplete. This causes the Bygg completion
functionality to not work and the relevant tests to fail.

For now, lock the Python versions to 3.11.8 and 3.12.2 in the code
quality workflow, for Nox and in .tool-versions.

Workaround for #138.
@rikardg rikardg self-assigned this Apr 16, 2024
rikardg added a commit that referenced this issue Apr 16, 2024
@rikardg
Upgrade argcomplete -> 3.3.0
16bfddf 
This version contains a fix for the API changes in argcomplete in Python
3.11.9 and 3.11.3.

Work on #138.
rikardg added a commit that referenced this issue Apr 16, 2024
@rikardg
Lock Python versions
5d72a18 
Lock Python versions down to patch versions 3.11.9 and 3.12.3 for mise
and the code_quality GitHub workflow.

Have nox use versions locked to minor versions 3.11 and 3.12 so that it
will use the latest matching version that is installed.

Close #138.
rikardg added a commit that referenced this issue Apr 16, 2024
@rikardg
Lock Python versions
083ebf5 
Lock Python versions down to patch versions 3.11.9 and 3.12.3 for mise
and the code_quality GitHub workflow.

Have nox use versions locked to minor versions 3.11 and 3.12 in
noxfile.py so that it will use the latest matching version that is
installed.

In the code_quality workflow, run nox with the explicit Python versions
defined in the workflow.

Closes #138.
@rikardg rikardg mentioned this issue Apr 16, 2024
Merged
rikardg added a commit that referenced this issue Apr 16, 2024
@rikardg
Upgrade argcomplete -> 3.3.0
e415931 
This version contains a fix for the API changes in argcomplete in Python
3.11.9 and 3.11.3.

Work on #138.
rikardg added a commit that referenced this issue Apr 16, 2024
@rikardg
Lock Python versions
98a0d2e 
Lock Python versions down to patch versions 3.11.9 and 3.12.3 for mise
and the code_quality GitHub workflow.

Have nox use versions locked to minor versions 3.11 and 3.12 in
noxfile.py so that it will use the latest matching version that is
installed.

In the code_quality workflow, run nox with the explicit Python versions
defined in the workflow.

Closes #138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rikardg rikardg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade argcomplete -> 3.3.0 and lock Python versions rikardg/bygg
1 participant
@rikardg