Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: controller error handling #97

Merged
merged 8 commits into from
May 10, 2023
Merged

feat: controller error handling #97

merged 8 commits into from
May 10, 2023

Conversation

MaloPolese
Copy link
Member

@MaloPolese MaloPolese commented Apr 24, 2023 •
edited
Loading

Closes #

📑 Description

Better error handling in controller

✅ Checks

  • My pull request adheres to the code style of this project
  • My code is documented
  • I provided unitary tests or procedure to test my code
  • My PR have a clear description of what my code is supposed to do

ℹ Additional Information

@MaloPolese MaloPolese self-assigned this Apr 24, 2023
@MaloPolese MaloPolese linked an issue Apr 24, 2023 that may be closed by this pull request
[FEAT]: Controller error handling #96
Closed
@MaloPolese MaloPolese force-pushed the 96-feat-controller-error-handling branch 2 times, most recently from f66d053 to 2d847fc Compare April 24, 2023 11:18
@MaloPolese MaloPolese marked this pull request as ready for review April 24, 2023 11:20
@MaloPolese MaloPolese requested a review from a team as a code owner April 24, 2023 11:20
alexandrebrg
alexandrebrg requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall that's great to have this kind of changes, it improves the code!

Still, I think the current changes don't match how we should be handling errors with public facing APIs, please check my comment about RikError to discuss it.

controller/src/api/external/routes/tenant.rs Outdated Show resolved Hide resolved
controller/src/api/external/routes/tenant.rs Outdated Show resolved Hide resolved
controller/src/api/mod.rs Outdated Show resolved Hide resolved
controller/src/database/mod.rs Outdated Show resolved Hide resolved
controller/src/database/mod.rs Outdated Show resolved Hide resolved
controller/src/database/mod.rs Show resolved Hide resolved
controller/src/database/mod.rs Outdated Show resolved Hide resolved
controller/src/api/mod.rs Outdated Show resolved Hide resolved
@MaloPolese MaloPolese force-pushed the 96-feat-controller-error-handling branch from 2d847fc to 8acf04a Compare May 7, 2023 14:44
@MaloPolese MaloPolese requested review from alexandrebrg and removed request for alexandrebrg May 7, 2023 14:44
alexandrebrg
alexandrebrg approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit change, otherwise LGTM

@MaloPolese MaloPolese merged commit 32f5be8 into main May 10, 2023
@MaloPolese MaloPolese deleted the 96-feat-controller-error-handling branch May 10, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebrg alexandrebrg alexandrebrg approved these changes

@croumegous croumegous Awaiting requested review from croumegous

@kalil-pelissier kalil-pelissier Awaiting requested review from kalil-pelissier

Assignees

@MaloPolese MaloPolese

Labels
scope/controller type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Controller error handling
2 participants
@MaloPolese @alexandrebrg