Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefull shutdown #90

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Gracefull shutdown #90

merged 6 commits into from
Apr 26, 2023

Conversation

kalil-pelissier
Copy link
Contributor

@kalil-pelissier kalil-pelissier commented Apr 12, 2023 •
edited
Loading

Closes #57

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code is documented
  • I provided unitary tests or procedure to test my code
  • My PR have a clear description of what my code is supposed to do

ℹ Additional Information

@kalil-pelissier kalil-pelissier requested a review from a team as a code owner April 12, 2023 20:54
@kalil-pelissier kalil-pelissier changed the title Gracefull shutdown Draft: Gracefull shutdown Apr 23, 2023
@kalil-pelissier kalil-pelissier self-assigned this Apr 23, 2023
@kalil-pelissier kalil-pelissier marked this pull request as draft April 23, 2023 20:38
@kalil-pelissier kalil-pelissier changed the title Draft: Gracefull shutdown Gracefull shutdown Apr 23, 2023
@kalil-pelissier kalil-pelissier force-pushed the feat/gracefull_shutdown branch 2 times, most recently from be38525 to 4a1e341 Compare April 24, 2023 12:48
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Apr 24, 2023
@kalil-pelissier kalil-pelissier added the type/enhancement New feature or request label Apr 24, 2023
@kalil-pelissier kalil-pelissier force-pushed the feat/gracefull_shutdown branch from 4a1e341 to ea51947 Compare April 24, 2023 16:07
@kalil-pelissier kalil-pelissier marked this pull request as ready for review April 24, 2023 16:08
@MaloPolese
Copy link
Member

Rebase + fix conflicts 😄

@kalil-pelissier kalil-pelissier force-pushed the feat/gracefull_shutdown branch from ea51947 to 1a81dce Compare April 25, 2023 08:09
@kalil-pelissier kalil-pelissier marked this pull request as draft April 26, 2023 07:34
@kalil-pelissier kalil-pelissier force-pushed the feat/gracefull_shutdown branch from 1a81dce to f1fbace Compare April 26, 2023 08:30
@kalil-pelissier kalil-pelissier force-pushed the feat/gracefull_shutdown branch from f1fbace to 45dcefb Compare April 26, 2023 09:52
@kalil-pelissier kalil-pelissier marked this pull request as ready for review April 26, 2023 10:08
alexandrebrg
alexandrebrg approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Small changes but otherwise we checked together that it's properly working so LGTM

riklet/src/core.rs Show resolved Hide resolved
riklet/src/core.rs Outdated Show resolved Hide resolved
riklet/src/runtime/network/function_network.rs Outdated Show resolved Hide resolved
@alexandrebrg alexandrebrg merged commit 38a3866 into main Apr 26, 2023
@alexandrebrg alexandrebrg deleted the feat/gracefull_shutdown branch April 26, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebrg alexandrebrg alexandrebrg approved these changes

@MaloPolese MaloPolese Awaiting requested review from MaloPolese

Assignees

@kalil-pelissier kalil-pelissier

Labels
type/documentation Improvements or additions to documentation type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement graceful shutdown
3 participants
@kalil-pelissier @MaloPolese @alexandrebrg