Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - Android crashes and card scrolling #559

Merged
merged 14 commits into from
Mar 10, 2023
Merged

Conversation

drewjhart
Copy link
Contributor

Prior to our demo, we noticed some crashes and scrolling issues on the Android side of the mobile app.

There is a crash associated with TextInputs in a FlatLiast which impacts PhaseOneGamePlay and PhaseTwoGamePlay. More information can be found here:
facebook/react-native#17530

This involves the styling of underline properties in a TextInput producing NullPointerException and hasn't been clearly addressed in the above issue to RN. I implemented the suggested solution (specifying the styling in the xml) and still ran into the issue. We don't actually need TextInput here though, so I've substituted them for Text and that resolved the issue.

There were also some issues with scrolling not working on Android. This PR also resolves that.

@@ -138,7 +138,7 @@ android {
applicationId "com.rightonnew"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 6
versionCode 8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct build number (and version 8 has been built through Android Studio). There was some last minute builds trying to get better crash reporting through bugsnap to understand the crash more but ultimately it was simpler to just swap out the unneeded and problematic TextInput

@drewjhart drewjhart merged commit 8759fb9 into dev Mar 10, 2023
@drewjhart drewjhart deleted the drew-hart-android-crashes branch September 6, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant