Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DefGate's no longer appear in the instructions list #1688

Merged
merged 13 commits into from
Nov 9, 2023
Merged

fix: DefGate's no longer appear in the instructions list #1688

merged 13 commits into from
Nov 9, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Oct 31, 2023 •
edited
Loading

Description

closes #1666, requires rigetti/quil-rs#306 to be deployed and pulled in, but all tests pass locally and this PR is otherwise code complete.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV requested a review from a team as a code owner October 31, 2023 21:38
@MarquessV MarquessV linked an issue Oct 31, 2023 that may be closed by this pull request
Defgates are in the instructions list #1666
Closed
@MarquessV MarquessV mentioned this pull request Oct 31, 2023
Merged
@rigetti-githubbot
Copy link

rigetti-githubbot commented Nov 1, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7084 6218 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_compiler_client.py 95% 🟢
pyquil/quil.py 83% 🟢
TOTAL 89% 🟢

updated for commit: dd8db7e by action🐍

jselig-rigetti
jselig-rigetti reviewed Nov 2, 2023
View reviewed changes
pyquil/quil.py Outdated Show resolved Hide resolved
@MarquessV MarquessV enabled auto-merge (squash) November 9, 2023 21:29
@MarquessV MarquessV merged commit 5249142 into master Nov 9, 2023
19 checks passed
@MarquessV MarquessV deleted the 1666-defgates-are-in-the-instructions-list branch November 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jselig-rigetti jselig-rigetti jselig-rigetti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defgates are in the instructions list
3 participants
@MarquessV @rigetti-githubbot @jselig-rigetti