Added support for string interpolation in bindings #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
requested changes
Apr 2, 2021
src/DotVVM.Framework/Compilation/Binding/ExpressionBuildingVisitor.cs
Outdated
Show resolved
Hide resolved
src/DotVVM.Framework/Compilation/Binding/ExpressionBuildingVisitor.cs
Outdated
Show resolved
Hide resolved
src/DotVVM.Framework/Compilation/Parser/Binding/Parser/BindingParser.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stanislav Lukeš <[email protected]>
Co-authored-by: Stanislav Lukeš <[email protected]>
Fixed building issues
|
Thanks for review. You were right - nested expressions were broken if they contained strings. It should be fixed now. Also formatting should now be supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #362. This PR adds support for string interpolation in bindings.
Interpolated strings are always translated into C#
String.Format(...)calls, unless a constant string is provided with no interpolation expressions. When compilingString.Format(...)calls to JavaScript, the functiondotvvm.globalize.format(...)is used.Implementation progress:
String alignment component(we decided that this will not be supported)