Static Commands in MarkupControl

[Mylan719]

I try to use static command as much as possible to make my pages faster. However I ren into a severe limitation. It is impossible to bind Command property to static command binding in the markup control.
Example:
Let's assume I have DeviceDetail markup control used in the page like so:

<cc:DeviceDetail Save={staticCommand: _root.Detail = service.Save(Detail); _alert.Show('Item saved')} />

I wanted to implement the DeviceDetail control as follows:

@viewModel MyProject.DeviceViewModel
@baseType MyProject.Device 
<div>
<!-- ... --/>
    <dot:Button Click={staticCommand: _control.Save()} Text="Save"/>
</div>

Code behind:

public class Device : DotvvmMarkupControl {
public Command Save
        {
            get { return (Command)GetValue(SaveProperty); }
            set { SetValue(SaveProperty, value); }
        }
        public static readonly DotvvmProperty SaveProperty
            = DotvvmProperty.Register<Command, Device>(c => c.Save, null);
}

This use case does not work as it generates client side JavaScript contetext.$control.Save() for the save button in the markup control. The Save property is not present in the $control context and attempt to press the "Save" button fails silently.

Since markup control properties of type Command generate no corresponding property into the $control client context no control commands can be called from staticCommand binding.

We need to correct this.

[exyi]

There is still the problem that the translator does not know that the command invocation will return a promise and thus won't wait for it. It works for the simplest cases when only one command is invoked, but will not work when the command result value would be used in a second step, or so.

[Mylan719]

There is still the problem that the translator does not know that the command invocation will return a promise and thus won't wait for it.

This issue has been resolved, now the translator wraps the control property invocation result into Promise.resolve. It also adds correct annotation to the invocation so the compiler takes the property call into account when deciding the command execution order.

[exyi]

Very nice, thank you for this patch. Would be nice if you resolve my nitpicks.

We can add support for arguments later (ideally, with the lambdas merged), but I think that is going to be relatively easy.

[Mylan719]

Nitpicks resolved ;)