Add support for variables in value bindings #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parser/resolver and value binding work is done. The PR is marked as WIP because static commands are not working right now. |
|
It now should work even in static commands. Arguably, the translation is a bit messy, but it works - we can probably improve the output JS code later. |
The syntax is `val variableName = value; nextExpression`. The variable is not assignable again - it is always immutable. Variable may shadow property names and variables defined ahead of it. The variable may be accessed only in the `nextExpression`. This version does not support automatic unwrapping Tasks. We wanted to switch to using await in DotVVM 3 anyway, right? see #776
acizmarik
approved these changes
Mar 11, 2021
| @@ -934,6 +934,29 @@ public void BindingParser_MultiblockExpression_EmptyBlockMiddle_Invalid(string b | |||
| Assert.AreEqual(node.EndPosition, lastExpression.EndPosition); | |||
| Assert.AreEqual(voidBlockExpectedLenght, middleExpression.Length); | |||
|
|
|||
| } | |||
| [DataRow("var x=A(); !x", "x", DisplayName = "Variable (val) expression")] | |||
There was a problem hiding this comment.
val instead of var in DisplayName
src/DotVVM.Framework/Compilation/Binding/StaticCommandBindingCompiler.cs
Outdated
Show resolved
Hide resolved
quigamdev
approved these changes
Mar 12, 2021
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax is
val variableName = value; nextExpression.The variable is not assignable again - it is always immutable.
Variable may shadow property names and variables defined ahead of it.
The variable may be accessed only in the
nextExpression.This version does not support automatic unwrapping Tasks.
We wanted to switch to using await in DotVVM 3 anyway, right?
see #776