Added configuration for view precompilation. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalTichy
requested review from
quigamdev,
tomasherceg and
exyi
and removed request for
quigamdev
exyi
reviewed
Jun 8, 2020
| { | ||
| if (BackgroundCompilationDelay.HasValue && Mode == ViewCompilationMode.Lazy) | ||
| { | ||
| throw new Exception($"{nameof(BackgroundCompilationDelay)} is not supported in {nameof(ViewCompilationMode.Lazy)} {nameof(Mode)}."); |
There was a problem hiding this comment.
BackgroundCompilationDelay must be null in ...
There was a problem hiding this comment.
We should also check that the delay is null when Mode is DuringStartup. That would only stop the startup, which does not make much sense.
exyi
reviewed
Jun 8, 2020
| @@ -93,7 +93,7 @@ public static IEnumerable<ControlUsageError> ValidateUsage(ResolvedControl contr | |||
| { | |||
| if ((int)delayProperty.Value < 0) | |||
| { | |||
| yield return new ControlUsageError("Delay cannot be set to negative number."); | |||
| yield return new ControlUsageError("BackgroundCompilationDelay cannot be set to negative number."); | |||
There was a problem hiding this comment.
Ups :O
I've reverted the change and modified all the messages in UpdateProgress to use nameof
|
It seems like that integration tests are failing - @MichalTichy please look at it. |
|
Tests seem to be ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration for view compilation modes.
Compilation modes are:
Current mode of compilation.
Compilation will run during application startup. Application will start after compilation is done.
Compilation will run after application startup.