Fixing various issues of multiblock expressions #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 8, 2020 23:54
…e VS test adapter can run the tests.
…h other operators.
Fixed errors in multiblock expression tests.
exyi
approved these changes
Apr 12, 2020
| var first = ReadUnsupportedOperatorExpression(); | ||
| if (Peek() is BindingToken operatorToken && operatorToken.Type == BindingTokenType.Semicolon) | ||
| { | ||
| Read(); | ||
| first = CreateVoidBlockIfBlankIdentifier(first, startFirstIndex); |
There was a problem hiding this comment.
This AFAIK also means that ; test is allowed 🤔
There was a problem hiding this comment.
I think I'd just disallow that, it seems quite suspicious...
| @@ -421,6 +434,7 @@ private BindingParserNode ReadAtomicExpression() | |||
| else if (token != null && token.Type == BindingTokenType.StringLiteralToken) | |||
| { | |||
| // string literal | |||
|
|
|||
src/global.json
Outdated
| "sdk": { | ||
| "version": "3.0.100-preview5" | ||
| } | ||
| } |
There was a problem hiding this comment.
Perfect! And the CI also seems to be happy without it :)
tomasherceg
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Testing multiblock expressions for use in intellisense of our VS extensions I noticed several imperfections.
Two semicolons one just after another are treated as single unknown operator.
test;;testIf white space is put between the semicolons like sotest; ;testit registers as three separate blocks. This is inconsistent. Expected result is: Identifier, Void block, Identifier, grouped into a blocks expression appropriately. This should be the same no matter the white space.Depending on the position of empty block inside a multiblock expression it registers A)
test; ;testas an empty identifier or B)test;test;as a void block. This inconsistency should be removed. An empty block should be always represented by void block in the syntax tree.Void block nodes always have 0 start position, wherever they occur. Thereby making it impossible to mark void block related errors correctly.
All these issues are addressed in this pull request. Along with fixing the bugs, I updated the test framework and removed legacy test config. The config, along with old version of test framework prevented me from running tests from VS Test Explorer. I also added new tests for multiblock expressions to check my changes.