Fixed passing of command arguments that are of non-primitive type #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command arguments must be deserialized with knowledge of the expected type. Apart from that, I also had to fix strange behavior of KnockoutHelper.GeneratePostbackExpression
… (it doesn't work when there is an input[type=text] in the page)
quigamdev
reviewed
Jun 19, 2020
| @@ -22,7 +22,7 @@ public void Feature_CommandArguments_CommandArguments() | |||
| var text = browser.Single("[data-ui='value']"); | |||
| AssertUI.InnerTextEquals(text, "Nothing here"); | |||
|
|
|||
| browser.Single("[data-ui='button'] button").Click(); | |||
| browser.Single("[data-ui='button1'] button").Click().Wait(); | |||
There was a problem hiding this comment.
I can't see any reason for using Wait() method here. Please use WaitFor().
tomasherceg
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command arguments must be deserialized with knowledge of the expected type.
Apart from that, I also had to fix strange behavior of KnockoutHelper.GeneratePostbackExpression