Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running UI tests on Linux #789

Merged
merged 4 commits into from
May 26, 2020
Merged

Support running UI tests on Linux #789

merged 4 commits into from
May 26, 2020

Conversation

cafour
Copy link
Contributor

@cafour cafour commented Nov 22, 2019

No description provided.

@exyi
Copy link
Member

exyi commented Nov 22, 2019

EDIT: sorry, posted a comment on the wrong PR

@exyi
Copy link
Member

exyi commented Nov 22, 2019

Just tried it and found out that it depends on internal release of "Riganti.Selenium.*" packages. We should avoid using these version in the master branch of DotVVM, if we want to keep this project open to anybody, it should be possible (and easy) to build it without special credentials.

@exyi
Copy link
Member

exyi commented Nov 22, 2019

And YES, it finally works on my machine 🎉 Thank you @ENgateman!

One more question, why does it default to http://localhost:16018 when the Asp.Net Samples start on port 5000? Is it possible to change the port from the command line or do I have to edit the json files?

@cafour
Copy link
Contributor Author

cafour commented Nov 23, 2019

I didn't realize I was using an internal release of Riganti.Selenium.*. We should probably merge this PR after we release that.

AFAIK the only way to change the port number is through seleniumConfig.json. It would be nice if one could at least override that with an environment variable.

@quigamdev
Copy link
Contributor

@ENgateman Version 2.0.5 of Riganti.Selenium was released. Could you upgrade it?

@cafour
Copy link
Contributor Author

cafour commented Apr 18, 2020

Updated 'em packages. Finally.

@quigamdev quigamdev merged commit c216c98 into master May 26, 2020
@cafour cafour deleted the linux-testing branch July 24, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants