Error event reported correctly in lazy CSRF mode #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI tests for Offline error event extended for the lazy CSRF case
exyi
approved these changes
Oct 3, 2019
Comment on lines
+391
to
+400
| var csrfToken; | ||
| try { | ||
| csrfToken = await this.fetchCsrfToken(viewModelName); | ||
| } | ||
| catch (err) { | ||
| this.events.error.trigger(new DotvvmErrorEventArgs(sender, this.viewModels[viewModelName].viewModel, viewModelName, null, null)); | ||
| console.warn(`CSRF token fetch failed.`); | ||
| errorCallback({ error: err }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Might have been cleaner to use await this.fetchCsrfToken(viewModelName).catch(err => ...)
There was a problem hiding this comment.
I didn't knew about that, but still - I need to use return in the catch clause so it doesn't help much here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #768 fixed the error event to be triggered correctly when the application is offline, however it didn't worked in lazy CSRF mode - when the CSRF token couldn't be obtained, it crashed without invoking such event.
This PR should fix this in lazy CSRF mode and cover this functionality with UI test making sure that all kinds of client-server communication will either succeed or raise the error event:
We should consider renaming the UI test to OfflineMode or something like this as it is not related only to SPA navigation.