Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper methods to build command binding expressions #1839

Merged
merged 5 commits into from
Aug 18, 2024

Conversation

tomasherceg
Copy link
Member

The bindingCompilationService.Cache already had methods to build value and staticCommand bindings.
I have added methods for creating command bindings as well.

Does resource binding also make sense here?

Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also include the methods for Resource bindings.

The reason why these methods aren't currently present is that command and resource binding can be created from a plain System.Func, without the need for JS translation.

@exyi exyi assigned exyi and unassigned exyi Aug 17, 2024
@exyi exyi changed the base branch from main to main-v4 August 17, 2024 22:49
@exyi exyi changed the base branch from main-v4 to main August 17, 2024 22:50
@exyi exyi changed the base branch from main to main-v4 August 17, 2024 22:50
@exyi exyi added this to the Version 4.3 milestone Aug 17, 2024
@exyi exyi force-pushed the feature/binding-service-cache-methods branch from f72d7fa to 89f5abe Compare August 17, 2024 22:50
@exyi exyi merged commit 50578ee into main-v4 Aug 18, 2024
14 of 16 checks passed
@exyi exyi deleted the feature/binding-service-cache-methods branch August 18, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants