Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dot:ModalDialog control, wrapper for <dialog> #1776

Merged
merged 5 commits into from
Feb 27, 2024
Merged

New dot:ModalDialog control, wrapper for <dialog> #1776

merged 5 commits into from
Feb 27, 2024

Commits on Feb 26, 2024

  1. New dot:ModalDialog control, wrapper for <dialog>

    The control closes or shows the modal based on an Open property.
    The modal is always shown using the .showModal() method,
    non-modal dialog is already accessible by binding the open
    attribute of dialog HTML element.
    The Open property may either be a boolean or a nullable object,
    the dialog is shown if the value isn't false nor null.
    
    On close event, false or null is written back into the Open property.
    Otherwise, we'd quickly have inconsistent viewModel whenever
    the user closes the dialog with ESC.
    Close event is also provided for explicit event handling.
    
    We also optionaly provide a helper for implementing
    "close after backdrop click" functionality. It is not supported by
    the dialog element natively and could not be otherwise
    implemented without writing custom JS.
    It is enabled by setting CloseOnBackdropClick=true
    
    Resolves  #1708
    exyi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    259476a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    479cb57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bf47a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6158f45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a473fd1 View commit details
    Browse the repository at this point in the history