Refactor RadioButton to unify client/server rendering #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
reviewed
Jul 12, 2023
| } | ||
|
|
||
| // if (!IsPropertySet(CheckedValueProperty)) |
There was a problem hiding this comment.
Please test if this would work without CheckedValue:
<dot:RadioButton Checked="{value: IsPerson}" GroupName="RadioGroup" Text="person" />
<dot:RadioButton Checked="{value: IsCompany}" GroupName="RadioGroup" Text="company" />
<p>Is person: {{value: IsPerson}}</p>
<p>Is company: {{value: IsCompany}}</p>
* all properties (Checked, Enabled, GroupName) will render both knockout expression and the value * if value binding is used and evaluation fails, the exception is ignored (as in HtmlGenericControl, new helper method was added for this) * GroupName now allows value bindings - this might be useful for usage in client-side Repeater resolves #1538
exyi
force-pushed
the
radiobutton-refactor
branch
from
190f1eb
to
2defae2
Compare
tomasherceg
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1538