Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializer: only inject properties to constructors of records #1525

Merged
merged 14 commits into from
Dec 10, 2022
Merged

serializer: only inject properties to constructors of records #1525

merged 14 commits into from
Dec 10, 2022

Commits on Nov 23, 2022

  1. Add failing sample for ViewModel Dependency Injection issue

    @luboshl
    luboshl committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    70df8f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Added ViewModelPopulate sample

    @tomasherceg
    tomasherceg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    a9cd936 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. serializer: only inject properties to constructors of records 

    People were relying on the serializer *not* calling the constructor
even when it contained what seemed to be properties. So we
need to restrict the "record" behavior to records and to classes
with explicitly marked JsonConstructor
    @exyi
    exyi committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3f0f102 View commit details
    Browse the repository at this point in the history

  2. serializer: test that we don't clone root viewmodel needlessly

    @exyi
    exyi committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    fd5397b View commit details
    Browse the repository at this point in the history

  3. serializer: handle init-only properties - always clone object when on… 

    …e is present
    @exyi
    exyi committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    cea0741 View commit details
    Browse the repository at this point in the history

  4. serializer: throw immediately when constructor needs to be called

    @exyi
    exyi committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1aaa54b View commit details
    Browse the repository at this point in the history

  5. serializer: disable cloning IDotvvmViewModel unless it has JsonConstr… 

    …uctor
    @exyi
    exyi committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    71e7527 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. serializer: Fix error for IDotvvmViewModel + init-only property

    @exyi
    exyi committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    ef8cf5a View commit details
    Browse the repository at this point in the history

  2. serializer: Tests for error reporting

    @exyi
    exyi committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    a0b8337 View commit details
    Browse the repository at this point in the history

  3. Extended tests for nested viewmodels

    @tomasherceg
    tomasherceg committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    d2cd139 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'serializer-nerf-records' of https://github.com/riganti/… 

    …dotvvm into serializer-nerf-records
    @tomasherceg
    tomasherceg committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    748093c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/view-model-dependency-injection' into serialize… 

    …r-nerf-records
    @tomasherceg
    tomasherceg committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    95f7cd2 View commit details
    Browse the repository at this point in the history

  6. Added samples and UI tests

    @tomasherceg
    tomasherceg committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    39a7f86 View commit details
    Browse the repository at this point in the history

  7. Merged changes from main

    @tomasherceg
    tomasherceg committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    8f2d1f9 View commit details
    Browse the repository at this point in the history