Fixed a couple of bugs for net472 framework build
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Expression.Convert`
|
LRU cache |
acizmarik
commented
Jun 22, 2022
| Assert.IsNotNull(updateExpr); | ||
| Assert.AreEqual("c.SetValueToSource(DotvvmBindableObject.DataContextProperty, Convert(newValue, Object))", updateExpr.ToString()); |
There was a problem hiding this comment.
We can use FastExpressionCompiler's ToCode method
exyi
approved these changes
Jun 24, 2022
Hopefully fixes random failures
acizmarik
force-pushed
the
fix/bugs-net-framework
branch
from
ffb3083
to
3960b22
Compare
acizmarik
force-pushed
the
fix/bugs-net-framework
branch
from
44b2c39
to
c31898d
Compare
Base automatically changed from
feature/make-unit-tests-runnable-net-framework
to
main
July 27, 2022 12:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs uncovered by running our unit tests also on .NET Framework.
#1424 should be merged first