Fix DotVVM.CommandLine packaging #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure it actually ever worked.
exyi
approved these changes
Apr 13, 2022
|
|
||
| <Target Name="AddCompilerToPublish" BeforeTargets="Publish;Pack"> | ||
| <ItemGroup> | ||
| <ToolsFile Include="$(OutputPath)\tools\**" /> | ||
| </ItemGroup> | ||
| <Message Text="$(PublishDir)" Importance="High" /> | ||
| <Warning Text="CommandLine should be packaged on Windows because of its dependency on Compiler!" Condition=" '$(OS)' != 'Windows_NT' "/> |
There was a problem hiding this comment.
I guess all publishing should be done on Windows so we build the net472 targets correctly.
There was a problem hiding this comment.
Yep. AFAIK it always has been.
Both the old publish pipeline on Azure Pipelines and the new one on GitHub Actions I'm trying to set up in my fork run on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the
DotVVM.CommandLinepackage did not contain theDotVVVM.Compilerdlls, which are required for thedotvvm lintcommand to work. (Honestly, I'm not even able to find a version that ever contained them.) Anyway, this PR addresses this bug.