Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VirtualPropertyGroupDictionary.Clear #1335

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fix VirtualPropertyGroupDictionary.Clear #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/Framework/Framework/Binding/VirtualPropertyGroupDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,32 @@ public void Add(KeyValuePair<string, TValue> item)

public void Clear()
{
// we want to avoid allocating the list if there is only one property
DotvvmProperty? toRemove = null;
List<DotvvmProperty>? toRemoveRest = null;

foreach (var (p, _) in control.properties)
{
var pg = p as GroupedDotvvmProperty;
if (pg != null && pg.PropertyGroup == group)
{
control.Properties.Remove(p);
if (toRemove is null)
toRemove = p;
else
{
if (toRemoveRest is null)
toRemoveRest = new List<DotvvmProperty>();
toRemoveRest.Add(p);
}
}
}

if (toRemove is {})
control.Properties.Remove(toRemove);

if (toRemoveRest is {})
foreach (var p in toRemoveRest)
control.Properties.Remove(p);
}

public bool Contains(KeyValuePair<string, TValue> item)
Expand Down