Fixed and improved serializability analyzers #1244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple of fixes and improvements to serializability analyzers.
GridViewDataSet<T>
,UploadedFilesCollection
andBusinessPackDataSet<T>
). They do not follow our general rules, however their serialization is well-defined and should not issue warnings.Compilation
within a specificSemanticModel
are no longer cached indefinitely. Instead, we now construct cache for eachCompilation
. These caches are held using weak references.Additionally,
DateTimeOffset
was added to supported types. Analyzers no longer generate serializability warnings for properties that implementIEnumerable
(however element type needs to be still serializable).