Prefer to use .state in staticCommands #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the annoying synchronization issues when state is updated in user code and staticCommand is invoked, which reads the old data :/
exyi
force-pushed
the
staticCommand-useState
branch
from
87f0fea
to
fa32049
Compare
acizmarik
reviewed
Jul 26, 2021
src/DotVVM.Framework/Compilation/Javascript/ParametrizedCode.cs
Outdated
Show resolved
Hide resolved
src/DotVVM.Framework.Hosting.AspNetCore/DotVVM.Framework.Hosting.AspNetCore.csproj
Outdated
Show resolved
Hide resolved
This is a hack, we should track which objects flow where, but it's easier to put a bunch of ko.unwraps where...
exyi
force-pushed
the
staticCommand-useState
branch
from
f73e02b
to
a93ade3
Compare
exyi
force-pushed
the
staticCommand-useState
branch
from
ee6a09e
to
bd6396f
Compare
A null Type was slipping into the ViewModelInfoAnnotation which lead to the SerializationMap being null. This null case is now handed. ExtensionParameter translation now has handling for the case when the parameter has null ParameterType, so less nulls should slip into the VM Info annotation
quigamdev
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the annoying synchronization issues when state is updated
in user code and staticCommand is invoked, which reads the old data :/