-
Notifications
You must be signed in to change notification settings - Fork 97
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
105 additions
and
55 deletions.
There are no files selected for viewing
105 changes: 105 additions & 0 deletions
105
src/Tests/Runtime/ControlTree/DefaultControlTreeResolver/CompilationWarningsTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using DotVVM.Framework.Utils; | ||
| using DotVVM.Framework.Controls; | ||
| using DotVVM.Framework.Compilation.Parser.Dothtml.Parser; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
|
|
||
| namespace DotVVM.Framework.Tests.Runtime.ControlTree | ||
| { | ||
| [TestClass] | ||
| public class CompilationWarningsTests : DefaultControlTreeResolverTestsBase | ||
| { | ||
| public (string warning, string tokens)[] GetWarnings(string dothtml) | ||
| { | ||
| var tree = ParseSource(dothtml, checkErrors: false); | ||
| return tree.DothtmlNode | ||
| .EnumerateNodes() | ||
| .SelectMany(n => n.NodeWarnings.Select(w => (w, string.Join(" ", n.Tokens.Select(t => t.Text))))) | ||
| .ToArray(); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void CompilationWarning_ValidationTargetPrimitiveType() | ||
| { | ||
| var warnings = GetWarnings($$""" | ||
| @viewModel {{typeof(TestViewModel)}} | ||
| <div Validation.Target={value: BoolProp}></div> | ||
| """); | ||
| Assert.AreEqual(1, warnings.Length); | ||
| StringAssert.Contains(warnings[0].warning, "Validation.Target should be bound to a complex object instead of 'bool'"); | ||
| Assert.AreEqual("BoolProp", warnings[0].tokens.Trim()); | ||
| } | ||
|
|
||
| [DataTestMethod] | ||
| [DataRow("TestViewModel2")] | ||
| [DataRow("VMArray")] | ||
| [DataRow("0")] | ||
| public void CompilationWarning_ValidationTargetPrimitiveType_Negative(string property) | ||
| { | ||
| var warnings = GetWarnings($$""" | ||
| @viewModel {{typeof(TestViewModel)}} | ||
| <div Validation.Target={value: {{property}}}></div> | ||
| """); | ||
| XAssert.Empty(warnings); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void DefaultViewCompiler_NonExistenPropertyWarning() | ||
| { | ||
| var markup = $@" | ||
| @viewModel System.Boolean | ||
| <dot:Button TestProperty=AA Visble={{value: false}} normal-attribute=AA Click={{command: 0}} /> | ||
| "; | ||
| var button = ParseSource(markup) | ||
| .Content.SelectRecursively(c => c.Content) | ||
| .Single(c => c.Metadata.Type == typeof(Button)); | ||
|
|
||
| var elementNode = (DothtmlElementNode)button.DothtmlNode; | ||
| var attribute1 = elementNode.Attributes.Single(a => a.AttributeName == "TestProperty"); | ||
| var attribute2 = elementNode.Attributes.Single(a => a.AttributeName == "normal-attribute"); | ||
| var attribute3 = elementNode.Attributes.Single(a => a.AttributeName == "Visble"); | ||
|
|
||
| Assert.AreEqual(0, attribute2.AttributeNameNode.NodeWarnings.Count(), attribute2.AttributeNameNode.NodeWarnings.StringJoin(", ")); | ||
| Assert.AreEqual("HTML attribute name 'TestProperty' should not contain uppercase letters. Did you intent to use a DotVVM property instead?", attribute1.AttributeNameNode.NodeWarnings.Single()); | ||
| Assert.AreEqual("HTML attribute name 'Visble' should not contain uppercase letters. Did you mean Visible, or another DotVVM property?", attribute3.AttributeNameNode.NodeWarnings.Single()); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void DefaultViewCompiler_NonExistenPropertyWarning_PrefixedGroup() | ||
| { | ||
| var markup = $@" | ||
| @viewModel System.Boolean | ||
| <dot:HierarchyRepeater ItemClass=AA ItemIncludeInPage=false /> | ||
| "; | ||
| var repeater = ParseSource(markup) | ||
| .Content.SelectRecursively(c => c.Content) | ||
| .Single(c => c.Metadata.Type == typeof(HierarchyRepeater)); | ||
|
|
||
| var elementNode = (DothtmlElementNode)repeater.DothtmlNode; | ||
| var attribute1 = elementNode.Attributes.Single(a => a.AttributeName == "ItemClass"); | ||
| var attribute2 = elementNode.Attributes.Single(a => a.AttributeName == "ItemIncludeInPage"); | ||
|
|
||
| Assert.AreEqual(0, attribute1.AttributeNameNode.NodeWarnings.Count(), attribute1.AttributeNameNode.NodeWarnings.StringJoin(", ")); | ||
| Assert.AreEqual("HTML attribute name 'IncludeInPage' should not contain uppercase letters. Did you intent to use a DotVVM property instead?", XAssert.Single(attribute2.AttributeNameNode.NodeWarnings)); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void DefaultViewCompiler_UnsupportedCallSite_ResourceBinding_Warning() | ||
| { | ||
| var markup = @" | ||
| @viewModel System.DateTime | ||
| {{resource: _this.ToBrowserLocalTime()}} | ||
| "; | ||
| var literal = ParseSource(markup) | ||
| .Content.SelectRecursively(c => c.Content) | ||
| .Single(c => c.Metadata.Type == typeof(Literal)); | ||
|
|
||
| Assert.AreEqual(1, literal.DothtmlNode.NodeWarnings.Count()); | ||
| Assert.AreEqual("Evaluation of method \"ToBrowserLocalTime\" on server-side may yield unexpected results.", literal.DothtmlNode.NodeWarnings.First()); | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters