Skip to content

Commit

Permalink
Merge pull request #1061 from riganti/readme-update-dotvvm-version
Browse files Browse the repository at this point in the history
Updated information in markdown files about new version of DotVVM
  • Loading branch information
tomasherceg authored Jul 14, 2021
2 parents 06debff + bfea58c commit 672d9f5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ There is also [dotnet new template](https://www.dotvvm.com/docs/tutorials/how-to

| | ASP.NET Core | OWIN |
|-------------------------|-----------------------------|-----------------------|
| Current stable version | `DotVVM.AspNetCore 3.0.4` | `DotVVM.Owin 3.0.4` |
| Current stable version | `DotVVM.AspNetCore 3.1.0` | `DotVVM.Owin 3.1.0` |
| Minimum runtime version | `.NET Core 2.1` | `.NET 4.5.1` |
| Minimum ASP.NET version | `ASP.NET Core 2.1` | `OWIN 3.0.1` |

Expand Down
6 changes: 3 additions & 3 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ First, start by choosing what you'd like to do - you can have a look at [issues

Then, you can fork the repo, clone it locally, and you are ready to develop.

Finally, you'll need to create a pull request to the `v3-master` (for DotVVM 3.0) or `master` branch (for DotVVM 2.5) (__we can help with that__), make sure that you have merged the latest changes and that the PR has a readable diff.
Finally, you'll need to create a pull request to the `v4-main` (for DotVVM 4.0) or `main` branch (for DotVVM 3.x) (__we can help with that__), make sure that you have merged the latest changes and that the PR has a readable diff.

**Please avoid reformatting documents, refactoring stuff, changing CRLF to LF or tabs to spaces etc. - it makes the PRs difficult to review.** There is definitely room for refactoring or cleanup, but it should be done in a separate PR so it is not messed up with functional changes.

Expand All @@ -44,13 +44,13 @@ If you plan to work with the DotVVM repository, here is a short manual what you

To get started, fork the repository, and clone it on or computer. You can use Visual Studio's Team Explorer window or run `git clone https://github.com/<your_github_username>/dotvvm.git`.

We are using Visual Studio 2019 or Visual Studio Code. Some projects use .NET Core 2.0 and .NET Core 3.1, so the solution will probably not open in previous versions of Visual Studio.
We are using Visual Studio 2019 or Visual Studio Code. Some projects use .NET Core 2.1, 3.1 and .NET 5.0, so the solution will probably not open in older versions of Visual Studio.

Open the `src/DotVVM.sln` solution in Visual Studio, or open the `src` folder in VS Code.

Set `Samples/DotVVM.Samples.BasicSamples.AspNetCore` as a startup project and launch it. It should just work - you'll see a page with a long list of samples (they are not often meaningful, they are used by the UI tests to verify all framework features work; however they are great for playing).

If the project does not start, feel free to ask us on [Gitter](https://gitter.im/riganti/dotvvm). For VS Code, launch it from the `src` directory, so it can find the `.vscode/launch.json` and `.vscode/tasks.json` files. You can also try to rebuild `Tests/DotVVM.Framework.Tests.Common` project and run the unit/integration tests - it should complete in few seconds, everything should be green. :)
If the project does not start, feel free to ask us on [Gitter](https://gitter.im/riganti/dotvvm). For VS Code, launch it from the `src` directory, so it can find the `.vscode/launch.json` and `.vscode/tasks.json` files. You can also try to rebuild `Tests/DotVVM.Framework.Tests` project and run the unit/integration tests - it should complete in few seconds, everything should be green. :)

Almost everying interesting is in the `DotVVM.Framework` project, except for some base interfaces and attributes in `DotVVM.Core` (so you don't have to reference the entire framework in your bussiess layer, if you just want to suppress serialization or turn on the validation of certain properties).

Expand Down

0 comments on commit 672d9f5

Please sign in to comment.