Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescaled grey16be colors using ffmpegs colorlevels to directly correct the original issue #101

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

itay-grudev
Copy link
Contributor

@itay-grudev itay-grudev commented Jan 9, 2024

This PR re-scales the grey16be colors using ffmpeg's colorlevels filter to directly reverse the original issue causing the image to be really dark.

Importantly, using this method the quality of small details is preserved, as opposed to gamma, brightness and contrast filters which significantly reduce the quality of text and small details and/or do not achieve the desired brightening effect.

Current solution on main since #100:

Screenshot from 2024-01-09 19-31-33

Improved version with colorlevels:

Screenshot from 2024-01-09 20-23-03

Fixes: #96

@itay-grudev
Copy link
Contributor Author

itay-grudev commented Jan 9, 2024

@rien The quality of the text is preserved with this fix and the brightness is at the levels it was before the v3 software update.

Copy link
Owner

@rien rien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that looks way better indeed. Thank you for the PR!

@rien rien merged commit 890961f into rien:main Jan 10, 2024
3 checks passed
@itay-grudev itay-grudev deleted the rescaled_grey16be_colors branch January 10, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also having a black screen
2 participants