fix(install-debian.yml): add task to gather package facts before unholding GitLab Runner version #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lding GitLab Runner version fix(install-debian.yml): add condition to unhold GitLab Runner version only if 'gitlab-runner' package is installed
|
When does this problem appears and when doesn't it? |
|
The problem appears when you install for a first time the gitlab-runner package. It's not possible to unhold a package that's not installed yet. |
|
I've test this PR in my solution and it fixes the issue. |
|
Even If I would be curious why this worked for me in the bast with Ubuntu and Debian, I'm going to merge it. I guess it doesn't harm anything. |
|
:) it seemd this has a lot of attention judging by the amount of people invoved in this conversation. @Wihrt thx for your contribution. Appreciate that. |
|
I used to stop this, since if people have a task to update apt, then this task alone also starts doing that. If all the roles you have update apt it could take a long time. But since a lot of people want it, why not. P.s. Gunther, if you can look at how to push to galaxy that would help too.
…________________________________
Van: Günther Grill ***@***.***>
Verzonden: Tuesday, January 9, 2024 4:11:24 PM
Aan: riemers/ansible-gitlab-runner ***@***.***>
CC: Subscribed ***@***.***>
Onderwerp: Re: [riemers/ansible-gitlab-runner] fix(install-debian.yml): add task to gather package facts before unholding GitLab Runner version (PR #303)
:) it seemd this has a lot of attention judging by the amount of people invoved in this conversation.
@Wihrt<https://github.com/Wihrt> thx for your contribution. Appreciate that.
—
Reply to this email directly, view it on GitHub<#303 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOIKDOSONUY3I727BBTYNVMZZAVCNFSM6AAAAABBLWPAGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGIZTCOBXGY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(install-debian.yml): add condition to unhold GitLab Runner version only if 'gitlab-runner' package is installed
Fixes #301