Remove the unnecessary and confusing hidden service self test

[Antaon]

Specs: Torsion v1.0.0-10-g2c52502 on Debian 7 (64bit) in VirtualBox:

Repro Steps:

1. Open the Torsion binary and successfully connect to the Tor network.
2. Click the "Preferences" button/icon.
3. Click the "Tor" tab.
4. Wait 3 minutes looking for a notice about "Closing stream for '[scrubbed].onion': hidden service is unavailable (try again later)."

Results:
The Torsion program is making onion connections when the user has no contacts. This is worrying.

Expected Result: The Torsion program only make authorized onion connection attempts.

Notes:
Perhaps these unexplained and failing onion attempts are expected behavior as Torison could be using a Hidden service for updates or for some other reason, but I don't recall any comment in the design or protocol documents mentioning it. Could it be attempting to connect to my own published ID (similar to how Torchat does it by default)?

[special]

You're right, that does seem suspicious ;)

At startup or when there's reason to believe that Tor was offline and is now back online, it attempts to connect to its own service as a self-test (source). That had valid intentions, but it's actually fairly useless right now: the only visible effect is that the word "Connected" changes to "Online", and a similar change in the Tor preferences page.

There aren't many cases where tor will believe it's able to establish circuits, but publishing a hidden service fails. The ones that do exist would be better addressed by getting more feedback out of tor. This had value before the circuit-established state was monitored, but I don't think it does anymore.