Skip to content

Commit

Permalink
*: tweak test configurations
Browse files Browse the repository at this point in the history
All of these tests are either timing out or OOM'ing under `race` or
`deadlock` under remote execution. A couple of them we bump up to the
`large` pool, and a few I'm skipping under `race` or `deadlock` to avoid
similar issues.

Epic: CRDB-8308
Release note: None
  • Loading branch information
rickystewart committed Dec 6, 2023
1 parent 315c305 commit eb71a83
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/ccl/backupccl/testgen/templates.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/ccl/streamingccl/streamingest/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ go_test(
],
data = glob(["testdata/**"]),
embed = [":streamingest"],
exec_properties = {"Pool": "large"},
shard_count = 16,
tags = ["ccl_test"],
deps = [
Expand Down
2 changes: 2 additions & 0 deletions pkg/server/application_api/sql_stats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ func TestStatusAPITransactions(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.UnderDeadlock(t, "test is very slow under deadlock")

testCluster := serverutils.StartCluster(t, 3, base.TestClusterArgs{})
ctx := context.Background()
defer testCluster.Stopper().Stop(ctx)
Expand Down
1 change: 1 addition & 0 deletions pkg/sql/colexec/colexecdisk/external_sort_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func TestExternalSortMemoryAccounting(t *testing.T) {
defer log.Scope(t).Close(t)

skip.UnderStress(t, "the test is very memory-intensive and is likely to OOM under stress")
skip.UnderRace(t, "likely to OOM due to increased memory pressure under race")

ctx := context.Background()
st := cluster.MakeTestingClusterSettings()
Expand Down
1 change: 1 addition & 0 deletions pkg/testutils/testcluster/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ go_test(
"testcluster_test.go",
],
embed = [":testcluster"],
exec_properties = {"Pool": "large"},
deps = [
"//pkg/base",
"//pkg/keys",
Expand Down

0 comments on commit eb71a83

Please sign in to comment.