Testing v0.25 #23
Comments
|
First test running locally using the go32v2 build in a DOSBox window. So far so good. Created a character and did a few dungeon runs. Basic functions & gameplay work as expected. Hitting [Enter] defaults to the first available monster as it should. Both the game and the editor agree on the stats now while viewing player data. I agree that /HMAINT and /FMAINT will be nice to have again. I run /FMAINT nightly so that callers don't have to wait several minutes if they're the first one playing. Will test on the BBS for a few days, gain some levels and report further. Great work! |
|
In 0.25 (dos) when going to Love Corner and hitting [D]ivorce i'll get the following (Note, I'm not married so not sure what happens yet if i was): Better get rid of the matrimonial bonds right away! If I pick No and then head to the Dungeons I'll see the following: The Dungeons of Drunghin ╕%-╣%- ╗%- ╕%-}L the is here When I exit the game and re-enter then things are once again displayed normally. |
|
I am able to recreate the divorce bug described by @xbit44, although it looks slightly different for me.
The event shows up in the news like this:
|
|
Can confirm on the Win64 build as well. Did this bug exist in previous versions? |
|
Version .20e does indeed allow the option to Divorce without being married. I just tried it on one of my .20e games here:
It does not show the corruption as in the current build, just a blank for the divorcee's name. |
|
Nice test. Looks to be a very old bug as 0.19 *Public Test 6 also allows
only it kicks you back to the BBS once you try.
…On Thu, Aug 5, 2021 at 6:14 AM CraigEMP ***@***.***> wrote:
Version .20e does indeed allow the option to Divorce without being
married. I just tried it on one of my .20e games here:
[image: image]
<https://user-images.githubusercontent.com/12660452/128355685-262533c0-2628-43fd-b809-d073cbcc197c.png>
It does not show the corruption as in the current build, just a blank for
the divorcee's name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2TW5IA2MS6A5THUVMLSNDT3KFELANCNFSM5BSNESPA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
... BBS'ing is Terminal
|
|
@xbit44 , quick question. Are you testing the game in "classic mode" or "new mode"? So far all my feedback has been for "classic". |
|
New mode for me CraigEMP.
…On Thu, Aug 5, 2021 at 9:40 AM CraigEMP ***@***.***> wrote:
@xbit44 <https://github.com/xbit44> , quick question. Are you testing the
game in "classic mode" or "new mode"?
So far all my feedback has been in "classic".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2TW5P7AZ7L2QRC34ZDQLLT3K5IFANCNFSM5BSNESPA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
... BBS'ing is Terminal
|
|
Thanks for checking the older versions, that saved me from going through the commit log to see what had changed! The divorce bug was caused by a For some reason this bug wasn't triggered when debugging via the Lazarus IDE, so that made it interesting to track down! |
|
Just pushed new binaries with the latest fixes! |
|
/FMAINT and /HMAINT both working. Divorce bug fixed. However, I got a funny response, playing as an unmarried male character:
Looking at the LOVERS.PAS file, it looks like the response is supposed to vary based on the character's gender, but the way it's coded makes it use the character's own gender to make the husband/wife determination rather than the gender of his/her would-be divorcee (who happens to be no one). Usurper/SOURCE/USURPER/LOVERS.PAS Line 768 in 82c5228 Tried it as a female character and got this: Suggestion: simply change it to "spouse" (just in this instance) so the game doesn't have to guess? |
That's funny, I saw that prompt about a dozen times while trying to get the debugger to trigger the error, and not once did I notice what it said!
This was my first thought as well, so that's what I'll do. |
|
I've been running v0.19 PT6 for so long, i'm not sure if this has changed. in .19 you will have NPC's playing along side you and when you level up they will send "grats" or other funny comments. When i play with .25 and press ctrl-w it never shows "on-line" npc's? |
I believe you're referring to "fake players" and their tendency to be "chatty". I remember this being a thing in .20e as well. The default is having two chatty fake players (lines 159 and 188 in USURPER.CFG). I honestly tend to tune the fake players out, but next time I test I'll pay closer attention to whether they show up. |
|
Looks to be a possible bug and not only with NPC's. I logged on with two
characters and in the main menu ctrl-w shows no one is on. But when
clicking from the logon screen it does.
…On Thu, Aug 5, 2021 at 8:26 PM CraigEMP ***@***.***> wrote:
you will have NPC's playing along side you and when you level up they will
send "grats" or other funny comments.
I believe you're referring to "fake players" and their tendency to be
"chatty". I remember this being a thing in .20e as well.
The default is having two chatty fake players (lines 159 and 188 in
USURPER.CFG). I honestly tend to tune the fake players out, but next time I
test I'll pay closer attention to whether they show up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2TW5L4LTDM2HQOPXXZMZTT3NI7BANCNFSM5BSNESPA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
... BBS'ing is Terminal
|
|
|
|
And then a ctrl-w when both are logged into Main street: |
|
There's a commit named "fake player garbage" showing changes made to ONLINE.PAS, which appear to make fake player interactions happen less frequently. d8801d3#diff-f512779367fe8844eeaa39c325d33780545c0e39adf5b835b52d35c932ef8dbf There's also an entry in the changelog linked to it which also calls out "^w" (Ctrl+W): Line 121 in 45c6a94 Maybe the fix from that time is preventing online players from being listed altogether? |
|
Good find. Yeah, it seems all inter-node coms are not working. Like when a new player enters the game, it should say "x" has joined or something like that. |
|
"fake player garbage" may be referring to the fact that For CTRL-W (and CTRL-T) it looks like those are global hotkeys that work at any menu, and so they're handled in the DDPLUS function for reading input. When I switched to RMDoor that functionality was lost. And it's a little weird for the doorkit to be calling routines in the main game, so I'll have to think about how to re-introduce that functionality. One easy option would be to just add it as a hotkey to the main menu, but then it wouldn't be global anymore, so not sure how much of a negative that would be. In fact it looks like it's already an undocumented hotkey on the main menu -- if you hit EDIT: I have a feeling the NPC activity is also triggered in DDPLUS, which would explain why it stopped in the switch to RMDoor. |
|
Aha yes -- I remember Jakob hacked ddplus to jam the global hotkeys in there. We could do similarly for rmdoor (not great design, I agree). |
|
I'm thinking a method for registering global hotkeys would make sense. The tricky part will be making sure they only execute at menus and not while entering text -- Jakob had a lot of different input routines, and this is probably why -- the one that supported global hotkeys was probably never called when entering your Alias for example. |
|
After thinking about it more, I don't think the switch from DDPlus to RMDoor was a good one, so I've just reverted to DDPlus again on a new branch. The only thing "gained" by the switch was making it work with Mystic on Linux, but the "don't write to the socket" feature I added to RMDoor could have been added to DDPlus just as easily. So if you'd like to give them a shot, these binaries should restore the lost event/global hotkey functionality. Since they're using DDPlus again, the original command-line parameters will be needed to launch it. https://github.com/rickparrish/Usurper/tree/ddplus/bin |
|
Thanks Rick! Note, I just see editor.exe for the dos version here: https://github.com/rickparrish/Usurper/tree/ddplus/bin/i386-go32v2 |
|
Oops, didn't notice the build failed so it committed as a delete instead of an update -- thanks for pointing that out! There's a binary there now. EDIT: I just realized the last time DDPlus was used was during the "only win32 and linux builds will be released" period, which is why the GO32V2 version initially failed to compile. So there's a lot of code commented out that says "Telnet can't..." that isn't needed for win32/linux, but may be needed for FOSSIL under GO32V2, so there's a pretty good chance a bit more work will be needed. |
|
Will the new DDPlus command use the /P like stated in the usurper.exe /? That said, i do see NPC's logging in and out again :)
|
|
I just noticed the "Edit" from your last post Rick. Perhaps that's why i'm not seeing anything on the client side.. |
|
There's new binaries to try out, which I tested on Synchronet and get remote I/O now. A while back I added code to set the USURP.CTL settings to "smart" defaults, so then the game wouldn't error out if USURP.CTL was missing, but one related to initializing the FOSSIL wasn't such a smart default, so that's why you didn't have any remote I/O before. And yes, the old /P syntax is the correct one to use now. |
|
Works as intended w/ Spitfire as well!
|
|
Looks like all the bugs that @CraigEMP and I have presented have been squished. Any specific areas of .25 that you would like tested just say the word. |
|
I'm also running the dos .25 on my spitfire bbs. My batch file looks like this for node 1: cd c:\sf\doors\usurper4 Use /N# for what node it is and /P to point to the drop file. |
|
Interesting! I swear I tried the /P switch and I couldn't get the game to start at all. That's when I dug around and found (in another thread) the information about the /D switch having replaced it. But perhaps that is my issue. The only other difference is that I'm using the "adf" fossil driver for DOS instead of bnu. I'll give it another shot with /P and see what happens. :) Thanks for the information. BlaZ |
|
You got it :D Hope that works.. I do remember having some issues as well when the switch to call the drop file changed some versions ago. |
|
Wow... yeah, that did it. Thanks so much! All seems good now. BlaZ |
|
So now the only "bug" I have to report for 0.25 is that it seems the intro splash screens are missing. When I start the game, I get the pause prompt that normally comes at the end of the splash screen, but there is nothing ahead of it. Were those removed? Or did I screw something else up? :) |
|
Awesome you got it working :) As for the splash screen issue access editor.exe and change the option on line 11 "INTRO-menu" to YES. |
|
Nah, I have that set to yes. I get the Intro menu. What is missing is the ANSI splash screen that comes BEFORE that intro menu. It's usually a skull, or a purple Usurper logo, and has some nifty little inspirational message like "sleep with all the babes!" on it. They switch up randomly whenever you start the game. It's not a big deal not having them. Just wondered if it was a "me" issue, or a "0.25" issue. |
|
Hmm, not sure what it is then. If I change that to NO it also removes the splash screen for me. |
|
Ahh, okay, so then you normally do get the splash screen before the menu? Then I've done something else wrong...lol. I'll look at it more and report back if I find out what it was. |
|
Do you see a file named USUTEXT.DAT in the DATA subdirectory? If yes, is it empty (0 bytes)? If yes, that's the problem. There's an issue that wipes out this file during install. I thought it was known at one point in time, but I can't seem to find any word here on it. You'll have to grab an intact copy of USUTEXT.DAT from one of the archives here to fix the problem: https://github.com/rickparrish/Usurper/tree/master/ORIGINAL%20ARCHIVES |
|
Thanks CraigEMP. That was it. That file is 0 bytes. I appreciate the information! |
|
Just curious if anyone knows of a way for a player to lower their drug addiction percentage other than levelling up? Does it lower over time? |
|
It does not :( this is IMO a flaw in the game as if you can't level up, or reach level 100, then I don't know how to increase mental stability or decrease drug addiction. |
|
That is precisely the problem 3 players in my game are having right now. If any future changes will be made to the code, I think having it diminish maybe 2% per day at cleanup, and mental stability increase maybe 1%, would be helpful. I was looking in the player editor, and it shows a different number than what the actual percentage of drug addiction is on the stats, so I'm afraid to try to reduce anyone's in there, as I don't know what those numbers mean. Mine for example is "57%" drug addiction, but in the player editor it shows me with "7" in that field. |
|
I think it actually does lower over time. I used to be one of those players that would hit enter repeatedly while looking for fights in the dungeon, and as we all know this behavior falls victim to glue sniffing every single time. :) I've learned to not spam the enter key for this reason. Anyway, I'm reasonably sure that drug addiction does go down as long as you can resist the urge to walk by bottles of glue and not sniff them. Pretty sure I've seen mine go back down to 0% after careful dungeon trips. |
|
Well, after almost a week, none of my players have had any automatic reduction in drug addiction. I was, however, able to reduce it in the Editor. Turns out that the weird numbers I was seeing was because the Editor I was running as a DOORWAY door was for a different version of the game. So I'm just an idiot. When I ran the proper Editor, the numbers were normal. |
|
Someone asked me what stat causes the "You miss your blow due to lack of concentration" message, and after tracing it back to the mental stability stat that reminded me of this thread! So I've just pushed an update that randomly decreases addiction and increases mental stability during maintenance. The rules are:
I'm open to suggestions on any of these rules if you think they're too unbalanced one way or the other. In addition to that, I implemented @CraigEMP's suggestion to spoil extra healing potions during maintenance. I'll follow up in #25 because it might need some additional consideration. Also, I don't have a game setup right now, so I didn't actually test these binaries. They compile and at quick glance the code looks correct, but would definitely be good to make a backup before trying them! |
|
I can confirm the updated win32 binary works fine. |
|
I just tried the new binaries for Linux and I still get the same issue hanging after getting past the intro menu, but I do have a little further notes. If I go right to team rankings from main intro menu I have to hold down a key and character by character the rankings will show. It's similar right after logging in and displaying the NPC quotes. Everything else is lightning fast, but it will seem like it's hung unless I hold down the space bar for example. This occurs on both 32bit and 64bit compiles. |
|
@BlaZZZed1980 thanks for confirming win32 is working. @tlm1234 What BBS software are you using? And can you share a screenshot of the config screen for the door? I'll try setting up with the same settings here so I can troubleshoot. Also, does it happen in all telnet clients or only some? |
|
Thanks, and attention is much appreciated! I'm using 64 bit linux with Syncronet. Telnet to bbs.lizardmaster.com and look at the team rankings from the main menu. You have to hold down a character for it to display. Everything else is lightning fast (until you login and get some of the random chatter from NPCs, but after that it seems fine again). These are the settings:
|
|
@rickparrish I usually use syncterm, but I tried Putty just now with the same result. |
|
@tlm1234 I was able to reproduce the issue, and have just pushed new binaries that fix it. The issue occurs any time the After fixing that a second issue cropped up with If there are other procedures that read and display a file, they may need a similar fix, so just keep your eyes open for screens where the first line looks OK but then every subsequent line is too far to the right. |
|
Wow, thank you very much @rickparrish! I have only used Synchronet in the Linux environment so I am unsure of the others. I'll start testing today. |
|
Hey all, following the suggestion in #27, there are now release archives that get built with every commit, which you can find here: https://github.com/rickparrish/Usurper/releases/tag/latest In the past I was manually building with each respective platform (ie a Windows 10 32bit VM for win32, Ubuntu 16.04 for linux32, etc), but now they're all built using a single Windows server that cross-compiles for the other platforms. I've tested the win32 and win64 binaries, but not the go32v2 or linux binaries, so please let me know if you try them and run into any problems. Thanks! |
|
Very cool -- thank you! And I just caught up on the whatsnew as well... the @ codes is cool! I'm getting the itch to start hammering on bugs again. |
|
Installed on my spitfire bbs. so far so good. Thanks Rick, Dan and team. Happy New Year all. |
|
For the dev build that was released, should the compiled date be current? |
|
Yeah I realized I forgot to update the date after pushing that change. Updated a couple more screens to read from ANS/ASC instead of hardcoding, and updated the date with those commits. Was holding off on pushing thinking I'd get more screens done, but probably going to go watch a movie with the family so will push what I have for now, which should create a new release with updated date. |
New issue for testing/tracking v0.25
TODO LIST
foundThe text was updated successfully, but these errors were encountered: