Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Dont require knownleader #456

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

chrisgray-vertex
Copy link
Contributor

According to hashicorp/consul#9776, the X-Consul-Knownleader is unreliable and is likely to be removed at some point. In current versions of Consul, the value will be false when doing streaming requests. This causes caches to get stale here.

The recommendation from the referenced issue is to not use the X-Consul-Knownleader: for anything.

@rickfast rickfast merged commit e7422ff into rickfast:master Dec 18, 2021
@chrisgray-vertex chrisgray-vertex deleted the dont-require-knownleader branch December 20, 2021 14:26
@windonis
Copy link

Hi all,

We need these commits. I wonder that, when will this commit be included in a tag?

Best Regards

@vbashko
Copy link

vbashko commented Mar 4, 2022

Not a Contribution.

Hi @rickfast, @chrisgray-vertex. It seems that the master build failed after this PR was merged and the change was never released to the maven central repo. Is there a way to re-build the project and release the library including this change?

Thanks!

@aswingit
Copy link

aswingit commented Oct 6, 2022

@rickfast @chrisgray-vertex Looks like the master build has failed after this PR was merged. Could you please review it? Observing that the "ServiceHealthCache" listener is not getting invoked as consuleResponse.isKnownLeader() is false in ConsulCache.onComplete()

@dlabey
Copy link

dlabey commented Jan 24, 2023

Any ETA for a release on this? Can you fix the build?

@dlabey
Copy link

dlabey commented Jan 24, 2023

@rickfast can you manually attempt to kick-off another Jenkins CI action from master?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants