Skip to content

Commit

Permalink
Only release references in unsubscribe
Browse files Browse the repository at this point in the history
We decided it's better to leave it to the caller when it's appropriate to release, cf. ReactiveX#1
  • Loading branch information
mttkay committed Oct 14, 2013
1 parent e0fb980 commit 7f6a0be
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ public void onCompleted() {
observerRef.onCompleted();
} else {
log("onComplete: target component released or detached; dropping message");
releaseReferences();
}
}

Expand All @@ -89,7 +88,6 @@ public void onError(Throwable e) {
observerRef.onError(e);
} else {
log("onError: target component released or detached; dropping message");
releaseReferences();
}
}

Expand All @@ -99,7 +97,6 @@ public void onNext(T args) {
observerRef.onNext(args);
} else {
log("onNext: target component released or detached; dropping message");
releaseReferences();
}
}
});
Expand Down

0 comments on commit 7f6a0be

Please sign in to comment.