select debugger gem dependent on ruby version #39
Conversation
pry-debugger depends on debugger, which cannot be installed on ruby>=2.0. An extensive, lengthy and sometimes unerving discussion can be found on cldwalker/debugger#125 On May 16, 2014, cldwalker suggested moving to byebug for rubies>=2. This is reflected in the change to Gemfile. modified: Gemfile
|
This is blowing up some of the travis builds, as their bundler doesn't know what Probably better to gate on |
pry-debugger depends on debugger, which cannot be installed on ruby>=2.0. An extensive, lengthy and sometimes unerving discussion can be found on cldwalker/debugger#125 On May 16, 2014, cldwalker suggested moving to byebug for rubies>=2. This is reflected in the change to Gemfile. As it turns out, travisci has problems working with the mri platform directive, so bacd782 has been reworked to resort to simple if-else logic.
|
I am sorry to cause this hassle. I was under the impression that travis would deal with gem to ruby requirments differently. Apparently, sometimes builds fail choking on gems requiring ruby > 1.9.3 and I do not want to mess with your test setup. Interestingly, 139.9 got through, but I lack the travis expertise to really understand the issue. Please excuse the noise ... |
|
It looks like you've hit some natural bitrot/bit shifting as |
|
I fixed up the rake and json_pure issues in #40 so if you can rebase this branch over master we should be testing just your changes (though there is no ruby 2.x in the travis matrix, so it might be worth extending that too) |
|
@richardc can you merge this PR into master? |
|
I'm waiting on @cruwe rebasing, as per the preceding comment. |
|
Stomped over this with #41 so closing |
|
Oh gosh ... it totally escaped my notice that I had a task there. So sorry! In any case, thanks for your work! |
pry-debugger depends on debugger, which cannot be installed on
ruby>=2.0. An extensive, lengthy and sometimes unnerving discussion can
be found on cldwalker/debugger#125
On May 16, 2014, cldwalker suggested moving to byebug for
rubies>=2. This is reflected in the change to Gemfile.
Thanks for your work on puppet-datacat! Cheers!