correct conditions #504
Open
correct conditions #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
added a commit
to olivroy/DiagrammeR
that referenced
this pull request
Nov 14, 2023
|
Sorry for the delay on this. And thanks for fixing these crazy statements! I have to revisit this soon to see if this still works as intended with the fix. It could indeed be that the bugged version works and there's not enough testing to see if the fixes here result in a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the implications are of that.
Doesn't seem to affect tests. but I thought I'd single those out as they could influence the condition checking.
The first 1 is trivial. but maybe the conditions in traversals could influence some calculations.
Edit: If you have an idea for a test, I wouldn`t mind adding on. The coverage suggests the cases were not covered before and after this change https://app.codecov.io/gh/rich-iannone/DiagrammeR/pull/504/blob/R/trav_in_until.R
I added another change, but let me know if you think it is correct or not, maybe you only meant to test for
length(from_column)?