Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Convert HYDRAD output to single H5 file #115

Closed
jwreep opened this issue Sep 30, 2020 · 6 comments · Fixed by #117
Closed

Feature request: Convert HYDRAD output to single H5 file #115

jwreep opened this issue Sep 30, 2020 · 6 comments · Fixed by #117

Comments

@jwreep
Copy link
Member

jwreep commented Sep 30, 2020

That is, take some permutation of .phy, .hstate, .ine, etc. files over some time range and convert it to a single H5 file. This would make sharing results significantly easier if we could deliver a single file.

This is also a lot easier to do in Python instead of writing a C-module.

What do you think?

@wtbarnes
Copy link
Member

Yes, I think this is a really good idea! I think this is sort of what I had in mind in #96? But maybe it needn't be that complicated. Actually, I think I have a good idea for what this would look like. I'm going to open a PR with a prototype before I forget 😅

@jwreep
Copy link
Member Author

jwreep commented Sep 30, 2020

Oops, missed that issue before making this post. Yes, same idea, though.

@wtbarnes
Copy link
Member

Should these be interpolated onto a uniform grid with each variable stored as a time-distance array? Or should each timestep be it its own dataset?

@sjbradshaw
Copy link

sjbradshaw commented Sep 30, 2020 via email

@jwreep
Copy link
Member Author

jwreep commented Sep 30, 2020

I would say that this should be to deliver the raw data, so do it without interpolation. The rest of the pydrad code could still interpolate afterwards, no?

@jwreep
Copy link
Member Author

jwreep commented Sep 30, 2020

I also agree with Steve that appending the units on the data would make things much clearer, particularly for new users of HYDRAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants