-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure as a Python package #98
Conversation
# Treat everything in single ` as a Python reference. | ||
default_role = 'py:obj' | ||
|
||
# -- Options for intersphinx extension --------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to enable nitpicky? Maybe not in this PR tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll leave it to a subsequent PR.
show-fixes = true | ||
output-format = "full" | ||
|
||
lint.select = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable all of them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments/questions but looks good to me.
I did not review the Python code or the docs that closely. I have some personal formatting issues for the examples but its so minor it isn't worth the time.
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
Thanks! Always happy to do a more thorough review of the examples later on down the road. The existing examples were adapted from my old mkdocs page. I'm going to leave future and improved examples to future PRs. |
Fixes #77
Fixes #100
Fixes #101
This PR restructures the entire repository as a Python package using
pybind11
. This supersedes #79.Remaining TODOs:
Add docs page on ebtel++ equations(moved to Update documentation to include EBTEL equations with area expansion and two fluid effects #96)Fix Windows tests(moved to Fix Windows installation on CI #100 )Update GHA to build wheels for all platforms(moved to Update CI to build wheels for all platforms #101)yum install boost-devel
hangs