Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a topic guide on deriving the ebtel++ equations #111

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

wtbarnes
Copy link
Member

@wtbarnes wtbarnes commented Sep 17, 2024

Fixes #96

This PR also:

  • refactors the return type of the simulation to be a bit more user-friendly and documented
  • updates the development install page to include Linux instructions
  • makes the docs landing page look a little nicer.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (fa19fd3) to head (d763fc3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ebtelplusplus/high_level.py 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   79.57%   80.50%   +0.93%     
==========================================
  Files          11       11              
  Lines         328      354      +26     
==========================================
+ Hits          261      285      +24     
- Misses         67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes added Test on Windows If this tag is present, run the test suite on Windows and removed Test on Windows If this tag is present, run the test suite on Windows labels Sep 17, 2024
@wtbarnes wtbarnes merged commit ab8a68d into rice-solar-physics:main Sep 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test on Windows If this tag is present, run the test suite on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to include EBTEL equations with area expansion and two fluid effects
1 participant