Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: jost font support, schedule tab, more dynamic sidebar resizing and memopt #16

Merged
merged 13 commits into from
Nov 23, 2024
Merged

feat: jost font support, schedule tab, more dynamic sidebar resizing and memopt #16

merged 13 commits into from
Nov 23, 2024

Conversation

AB-102
Copy link
Collaborator

@AB-102 AB-102 commented Nov 18, 2024 •
edited
Loading

  • refactored sidebar with new component SidebarTab
  • fixed sidebar button hitboxes
  • fixed the swipe gesture sidebar toggle crashing on ios/android
  • added schedule sidebar tab and placeholder
  • added dynamic resizing for sidebar icons and text
  • added fading conditional mounting of sidebar elements for memory
  • added support for Jost font and weights

Tested on web, iphone, android tablet.

Apply the "font-jost" class to use Jost. The weight classes are defined in tailwind.config.js.
Ex:
<Text className="font-jost font-semibold">Text</Text>

@AB-102 AB-102 changed the title Feat: font, schedule page, sidebar memopt feat: font, schedule pagerefactor: sidebar memopt Nov 19, 2024
@AB-102 AB-102 changed the title feat: font, schedule pagerefactor: sidebar memopt feat: font, schedule page, sidebar dynamic resizing and memopt, fix: sidebar hitboxes, refactor: sidebar Nov 19, 2024
@AB-102 AB-102 mentioned this pull request Nov 19, 2024
Open
@AB-102 AB-102 changed the title feat: font, schedule page, sidebar dynamic resizing and memopt, fix: sidebar hitboxes, refactor: sidebar feat: jost font support, schedule tab, more dynamic sidebar resizing and memopt Nov 19, 2024
trihoang0809
trihoang0809 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@trihoang0809 trihoang0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trihoang0809 trihoang0809 merged commit 3a9e58a into main Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trihoang0809 trihoang0809 trihoang0809 approved these changes

@trietmchau trietmchau Awaiting requested review from trietmchau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AB-102 @trihoang0809