Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added typedef for butterfly #3

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Added typedef for butterfly #3

merged 2 commits into from
Oct 21, 2023

Conversation

duongaaron
Copy link
Collaborator

No description provided.

@duongaaron duongaaron requested a review from victor-xie October 21, 2023 18:57
victor-xie
victor-xie reviewed Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@victor-xie victor-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the photoUrl required? We would prefer not to have butterflies in our app without images, as that would make identification by our users very difficult.

victor-xie
victor-xie approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@victor-xie victor-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! First PR!

@victor-xie victor-xie merged commit 81c51ac into main Oct 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-xie victor-xie victor-xie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duongaaron @victor-xie