Add Challenges / Resources "View all" Pop-up screen #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCufino
requested changes
Mar 30, 2024
There was a problem hiding this comment.
Good start, but I think the implementation needs to be more in-line with the Final Wireframes figma:
The view-all screens should be pop-ups that grey out the rest of the screen, and clicking out of it should close it. There should be no explicit "close" button.
Also, the text padding and spacing doesn't seem to be completely in-line with the figma. The check circle needs to be scooted to the left some more to give the text more space on the right and the spacing between the pop-up, circle, and text needs to be equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pop-up screen