-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy multiple #32
Merged
Merged
Deploy multiple #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every comment has been either answered or applied |
fsilberstein
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Great job 👍
When you create the release, maybe use a major version because of the breaking change for the flag name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is too many connector to deploy, the distributed kafka-connect workers may have problem to handle the load.
Currently the cli only handle them one by one, so we resorted to to it in parallel in the bash itself.
But error handling and throttling it in bash is painful.
So why not do that in the cli.
Changes:
In lib, add feature
DeployMultipleConnector
with a max parallel deployment fixed to 3.Multiple error will be aggregated and returned once all connectors configs given have been tried.
Rework a bit the add the first unit tests. They are still not yet automatically executed.
Mostly isolated the low level client which only implement the kafka-connect API from the higher level client which expose all the custom feature we use. Such as
DeployMultipleConnector
.In cli make the
--file
argument support referencing a folder.cli will try to parse every files in this folder. No subfolder will be searched.
Goal is to reference a folder full of config to deploy and forget the parallelism/error handling on the bash side.