Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log commit author and skip assign issues not created #63

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

sidsprasad
Copy link
Contributor

  • Logging the commit author while retrieving from API
  • In some cases (Like ADD_LIMIT being set), some issues might not have been created. In those cases, skip assigning the issue.

@sidsprasad
Copy link
Contributor Author

@ribtoks
While running in my repo, I came across two issues.

  1. If the issue wasn't created in the first place, it still tries assigning the author, so added a condition to skip that over here.
  2. All the issues were being assigned to me for some reason. So, logging the commit hash here, and will verify with the API why it is getting me as the author. Also good to log this info anyway.

@ribtoks ribtoks merged commit ec63fe8 into ribtoks:master Jan 23, 2024
@sidsprasad
Copy link
Contributor Author

@ribtoks I ran this again on my repo and the issue is that the Commit API was never actually called.

So there's two possible reasons for this:

  1. tdg doesn't return commithash properly and so Line 381 is never true.
  2. commitToAuthorCache is misbehaving, and Line 357 is always returning hits. This is more likely the cause as the size of issueTitleToAssigneeMap is correct.

Will create another PR to add another line of logging to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants