Populate repo that "works" with GPGME #10
Conversation
| # | ||
| # # Seed global randomization in this process using the `--seed` CLI option. | ||
| # # Setting this allows you to use `--seed` to deterministically reproduce | ||
| # # test failures related to randomization by passing the same `--seed` value |
| # config.profile_examples = 10 | ||
| # | ||
| # # Run specs in random order to surface order dependencies. If you find an | ||
| # # order dependency and want to debug it, you can fix the order by providing |
| ENGINE_RAILS_ROOT=File.join(__dir__, '../') | ||
| Dir[File.join(ENGINE_RAILS_ROOT, "spec/factories/**/*.rb")].each {|f| require f } | ||
| ENGINE_RAILS_ROOT = File.join(__dir__, "../") | ||
| Dir[File.join(ENGINE_RAILS_ROOT, "spec/factories/**/*.rb")].each { |f| require f } |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Line is too long. [82/80]
| # http://stackoverflow.com/questions/22860025/rails-4-mounted-engine-with-rspec-and-factory-girl-rails | ||
| ENGINE_RAILS_ROOT=File.join(__dir__, '../') | ||
| Dir[File.join(ENGINE_RAILS_ROOT, "spec/factories/**/*.rb")].each {|f| require f } | ||
| ENGINE_RAILS_ROOT = File.join(__dir__, "../") |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -57,7 +57,7 @@ module Rails::Keyserver | |||
| end | |||
| end | |||
|
|
|||
| describe ".grip" do | |||
| xdescribe ".grip" do | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
| end | ||
|
|
||
| describe ".add_uid_params" do |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # io = IO.for_fd fd | ||
|
|
||
| def io.write stuff | ||
| @buffer ||= "" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| io = IO.new 2 | ||
| # io = IO.for_fd fd | ||
|
|
||
| def io.write stuff |
There was a problem hiding this comment.
Use def with parentheses when there are parameters.
| end | ||
|
|
||
| it "reads from the key" do | ||
| pending "TBI mock IO" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
| end | ||
|
|
||
| it "reads from the key" do |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
"Works" as in "uses", as this is a WIP that still has tests failing.
This is not meant to be directly merged into the mainline code as is, not even with tests fixed. This is meant only to be for referencing purposes for anyone who'd like to extract out the GPGME-specific bits into a GPGME adaptor for rails-keyserver.
For #2 and #3