Some UX issues with the new selection box #38

ronaldtse · 2017-08-18T14:56:30Z

Enabling SQS monitor should by default select "Defined in SCM / Pipeline script".

Currently it defaults to "Manually enter it" but should default select "Defined in SCM".

ronaldtse · 2017-08-18T14:58:53Z

In the red rectangle, there should only be 1 line instead of 2 for clarity.

We should also allow monitoring more than one SQS queue. Maybe we should move the "SQS queue to monitor" in the "Add" section so each repo could monitor a separate queue?

ronaldtse · 2017-08-18T15:01:47Z

A bit more UI adjustment.

ronaldtse · 2017-08-18T15:04:48Z

Also, when "Defined in SCM / Pipeline script" is enabled, the two "?" buttons on the right do not show anything. If "Manually enter it" is selected, it does show the help message.

Text changes:

"Defined in SCM / Pipeline script" to "Auto-detect CodeCommit URL and branches from SCM / Pipeline script"
"or Manually enter it" to "Manually enter CodeCommit URL and branches".

phuonghuynh · 2017-08-19T05:41:00Z

@ronaldtse

https://user-images.githubusercontent.com/11865/29464492-9f80c2e2-8468-11e7-9680-6b95c563ec74.png

Which ENV you getting this? We are using default Jenkins Form Controls, so we need to figure out this issue.

phuonghuynh · 2017-08-19T05:42:23Z

@ronaldtse

https://user-images.githubusercontent.com/11865/29464386-54e49ad8-8468-11e7-8f7e-f0fb8892a84d.png

We should have only one section for this (dont repeat it)

ronaldtse · 2017-08-19T07:32:16Z

@phuonghuynh by default when I enable the plugin, the "Manually enter" is already selected it. I don't know what you mean by "ENV"?

What do you mean "only one section for this"? We can allow 1 auto detect repo and multiple manual repos?

phuonghuynh · 2017-08-19T08:55:23Z

Yes, we can

I don't know what you mean by "ENV"?

I would like to know the browser you are seeing this, mostly this issue related to the Browser version.

phuonghuynh · 2017-08-21T04:09:58Z

@ronaldtse fixed some UX as bellow, could you give some feedbacks :)

ronaldtse · 2017-08-21T05:02:38Z

@phuonghuynh ah I'm using Chrome and Safari on macOS.

The UX changes look good!

Does the bottom section (CodeCommit Repo URL + Subscribed branches) automatically appear when you enable the "Build when a CodeCommit..."? Or should it be only shown after clicking on "Manually enter CodeCommit URL and branches"?
If the "Manually enter CodeCommit URL and branches" button is clicked on, it will provide an additional form "CodeCommit Repo URL" + "Subscribed branches..." below, right?
For auto-detect, should the user manually copy/paste it into the form, or not?

I see 3 cases we should handle:

If the user enables "Auto-Detect CodeCommit URL...", we don't even need to show the form (CodeCommit Repo URL + Subscribed branches ...). If the user wants auto-detect and wants to add an additional manual repo, he can click on "Manually enter ..." to do that.

If the user only wants to add manual, he will untick the "Auto-Detect..." and click on "Manually enter CodeCommit URL"

If the user wants Auto-Detect CodeCommit URL and then override, then the user should actually disable the "Auto-Detect ..." check box, and enter the URL manually. We should add a comment about it inside the bottom of the "Auto-Detect CodeCommit URL..." section.
If the user wants both:

phuonghuynh · 2017-08-21T05:30:55Z

@ronaldtse I think 2) and 3) is the same, user can untick the "Auto-Detect..." and do "Manually..." for both case.

If the user enables "Auto-Detect CodeCommit URL...", we don't even need to show the form (CodeCommit Repo URL + Subscribed branches ...). If the user wants auto-detect and wants to add an additional manual repo, he can click on "Manually enter ..." to do that.

If the user only wants to add manual, he will untick the "Auto-Detect..." and click on "Manually enter CodeCommit URL"

If the user wants Auto-Detect CodeCommit URL and then override, then the user should actually disable the "Auto-Detect ..." check box, and enter the URL manually. We should add a comment about it inside the bottom of the "Auto-Detect CodeCommit URL..." section.

If the user wants both:

You think its OK if repeat the label "Manual Subscription" for each section ?

ronaldtse · 2017-08-21T05:35:37Z

Yeah I think we can repeat the "Manual Subscription" part.

Let's rename "Subscribed to" to "Subscribed to Auto-Detected CodeCommit Repos"
Let's use a smaller font (and italicized if possible) for the "Subscribed to" and "Manual Subscription" headers?

phuonghuynh · 2017-08-21T06:05:18Z

To take a look on font-size

ronaldtse · 2017-08-21T06:06:26Z

@phuonghuynh do you think the "Manual Subscription" header should be italicized too?

phuonghuynh · 2017-08-21T06:10:26Z

yes, already

phuonghuynh · 2017-08-21T07:10:45Z

@ronaldtse for the pipeline job, if user select "Auto..." it will warning that the Trigger will read last Build SCM info, as bellow

phuonghuynh · 2017-09-28T14:22:46Z

This issue should be closed, we could post new issues if any UI need to be updated,

* Remove display uri-api & structs plugins * Add test for multi threads spec * Fix Queue list not saved

* Enable squash in JGitflow * Update .travis.yml to support integration test * Move to new namespace * Add display-url-api to test scope * Suppress FB issue RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * Fix test plugins too old * Enable squash in JGitflow * Update .travis.yml to support integration test * Move to new namespace * Add display-url-api to test scope * Suppress FB issue RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * Fix test plugins too old * Remove redundant code since we use new namespace * Update pom version * Update release plugin * updating poms for 1.7-SNAPSHOT development * updating poms for 1.8-SNAPSHOT development * updating poms for branch'release-1.7' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Test subscribe branches without wildcards, multiple projects * Test for mactching branch names * Load SCM urls to support user not confused the config * Keep scm urls transient var * Update link in htmls * Update beta version * Update pom to beta-1 * Supress NP_NULL_ON_SOME_PATH fidbug flag * Update Readme * Text update * Update text & fix findbugs warnings * updating poms for 1.8-beta-2-SNAPSHOT development * updating poms for branch'release-1.8-beta-1' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Update build badge to use ci.jenkins.io one & cache travis mvn repo * Update version to prepare release * updating poms for 1.8 branch with snapshot versions * updating poms for 1.9-SNAPSHOT development * updating poms for branch'release-1.8' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Update match function for repo url * Update Log info * Add more logs * updating poms for 1.10-SNAPSHOT development * updating poms for branch'release-1.9' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Match original branch * updating poms for 1.11-SNAPSHOT development * updating poms for branch'release-1.10' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Better logger support * Correct description of trigger in project page * Refine logs in activity action * Update test IT * Test for issue #30 * Fix test issue #30 not start Job * updating poms for 1.12-SNAPSHOT development * updating poms for branch'release-1.11' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Shorten log & unset jackson version * Pipeline support implementation * Update tests * Refactor activity log * View activity log in raw format * Add clear button * Fix findbug warning * Fix findbugs NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE * Change file name to activities * No need to recreate action many times * Fix message showing var address * Remove log output file function * updating poms for 1.13-SNAPSHOT development * updating poms for branch'release-1.12' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Support manually enter SCM url * Implement for pipeline new design * Support multi repo match * Fix Test Failure Error * Fix Single test failures * Log level changes * Log refactoring * Add IR test * Fix multiple fixture tests failure * updates documentation with region not found error * updating poms for 1.13 branch with snapshot versions * updating poms for 1.14-SNAPSHOT development * updating poms for branch'release-1.13' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Fix multi project fixture test * Add one checkbox for Subscribe Internal SCM only * Support new GUI as well as select Region in SQS setting page * Fix test compile failed * Fix test SQS function * Support jenkins 2.7x * Update test harness version * Update default jenkins parent pom and downgrade test harness version * Fix Jenkins build failure test due to script security version * Fix no sqs scm is found * Fix Subscribe Branch tests * Fix test result fail * Fix issues tests * Fix findbugs issue * updating poms for 1.15-SNAPSHOT development * updating poms for branch'release-1.14' with non-snapshot versions * updating develop poms to master versions to avoid merge conflicts * Updating develop poms back to pre merge state * Update test script * Migrate to new structure * Update aws sqs jar * Remove comments * Remove redundant dependencies * Update shade name * Prepare for release snapshot sub module * Reconfigure POMs for next release * update versions for release * Skip test project * update for next development version * Add changelog file * To invoke Jenkins CI test dependencies version (#35) * Add pipline test framework * Update timeout to 1.5m * Add test specs * Jenkins IT for internal scm config * External SCM IT * Remove Trigger test * Add credentials feature * Add new feature Aws Credential * Remove some FB Suppress checks * Try fix NULL FB for getName function * Fix up FB warning * Fix findbug null issue in SQSTriggerQueue * Add feature to migrate to new version * Fix findbug issue Nonnull * Fix findbugs null pointer issue in sqs queue class * Submit Migration test case * Fix Jenkins CI test failure due to pipline model definition version * Use workflow job v2.6 * Try to fix version compettiple * Try to fix scm-step version 2.3 * Fix workflow job v2.9 * Add workflow scm to test * Update changelog * update versions for release * update for next development version * Support non-interactive installation * update versions for release * update for next development version * Fix queue not saved (#38) * Remove display uri-api & structs plugins * Add test for multi threads spec * Fix Queue list not saved * update versions for release * update for next development version * Update change log * Make the "Access Test" more complete (#39) * Make the "Access Test" more complete with trying multiple permissions via multiple actions * Return Credentials not null * update versions for release * update for next development version * Support print out User Invoked

ronaldtse changed the title ~~Enabling SQS monitor should by default select "Defined in SCM / Pipeline script"~~ Some UX issues with the new selection box Aug 18, 2017

phuonghuynh self-assigned this Aug 18, 2017

phuonghuynh mentioned this issue Aug 28, 2017

Remove Trigger field subscribed_branch #32

Closed

phuonghuynh closed this as completed Sep 28, 2017

phuonghuynh added a commit to phuonghuynh/aws-codecommit-trigger-plugin that referenced this issue Oct 2, 2017

Fix queue not saved (riboseinc#38)

158e7d4

* Remove display uri-api & structs plugins * Add test for multi threads spec * Fix Queue list not saved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some UX issues with the new selection box #38

Some UX issues with the new selection box #38

ronaldtse commented Aug 18, 2017 •

edited

Loading

ronaldtse commented Aug 18, 2017

ronaldtse commented Aug 18, 2017

ronaldtse commented Aug 18, 2017

phuonghuynh commented Aug 19, 2017

phuonghuynh commented Aug 19, 2017

ronaldtse commented Aug 19, 2017 •

edited

Loading

phuonghuynh commented Aug 19, 2017 •

edited

Loading

phuonghuynh commented Aug 21, 2017 •

edited

Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017 •

edited

Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017 •

edited

Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017

phuonghuynh commented Sep 28, 2017

Some UX issues with the new selection box #38

Some UX issues with the new selection box #38

Comments

ronaldtse commented Aug 18, 2017 • edited Loading

ronaldtse commented Aug 18, 2017

ronaldtse commented Aug 18, 2017

ronaldtse commented Aug 18, 2017

phuonghuynh commented Aug 19, 2017

phuonghuynh commented Aug 19, 2017

ronaldtse commented Aug 19, 2017 • edited Loading

phuonghuynh commented Aug 19, 2017 • edited Loading

phuonghuynh commented Aug 21, 2017 • edited Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017 • edited Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017 • edited Loading

ronaldtse commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017

phuonghuynh commented Aug 21, 2017

phuonghuynh commented Sep 28, 2017

ronaldtse commented Aug 18, 2017 •

edited

Loading

ronaldtse commented Aug 19, 2017 •

edited

Loading

phuonghuynh commented Aug 19, 2017 •

edited

Loading

phuonghuynh commented Aug 21, 2017 •

edited

Loading

phuonghuynh commented Aug 21, 2017 •

edited

Loading

phuonghuynh commented Aug 21, 2017 •

edited

Loading