Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pplacer threads to 1 in processor.py #232

Closed
wants to merge 1 commit into from

Conversation

Anna-MarieSeelen
Copy link

Temporarily Fixes #231
Long-term maybe another solution is preferred.

@rhysnewell
Copy link
Owner

Hi @Anna-MarieSeelen,

This wouldn't be our preferred solution to this. However, this may work for you currently. I think adding back in an optional parameter (--pplacer-threads), which is only used when the user supplies would be ideal.

@AroneyS, Have you come across this issue with gtdb-tk and pplacer in the QUT HPC? #231

@AroneyS
Copy link
Collaborator

AroneyS commented Nov 26, 2024

I have not seen this issue, but I haven't run GTDBtk through Aviary for a while.
I second the readdition of the pplacer threads argument.

@Anna-MarieSeelen
Copy link
Author

Thank you for your response! 😊 I understand this isn’t the preferred solution, but I just wanted to share my temporary fix in case it helps anyone in the meantime. Since you indicated that this temporary fix likely won’t be used, I’ll go ahead and close the pull request.
Reintroducing the optional --pplacer-threads parameter sounds like a great long-term solution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot allocate memory GTDB-Tk
3 participants