das_tool: Use script not shell. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwood
requested review from
AroneyS and
rhysnewell
and removed request for
AroneyS
|
Does DAStool work if there is only 1 set of bins provided? I'm actually a bit confused why the test was working before I adjusted (it was only running semibin, I think) |
rhysnewell
reviewed
Dec 14, 2023
rhysnewell
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Basically converting the logic of the shell commands in the das_tool rule into a script, where a bit more care is taken.
There is a small functional difference. If a binning method has been run, but then rerun with that method in skip-binners. Previously bins from that binner were included, now they are not since the
Fasta_to_Scaffolds2Binscript is only run for requested binners.