Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SingleM metapackage downloading #173

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented Nov 28, 2023

  • Add to README
  • Add to downloads
  • Only download specified databases

why are there so many different places?
@rhysnewell rhysnewell changed the base branch from main to dev November 28, 2023 04:16
@AroneyS
Copy link
Collaborator Author

AroneyS commented Nov 28, 2023

@rhysnewell Can I change the download arg to multi-input arg: --download gtdb singlem eggnog checkm2? So that you don't have to download all databases to get 1. It is a breaking change though

@rhysnewell
Copy link
Owner

rhysnewell commented Nov 28, 2023

Yeah, sure thing. I'd like to setup semantic version so we care less about version numbers, so it's no big deal. Just preface your commit with 'feat: add down multi flag' so we know to increment via a major and not minor version on next release

only download specified databases
@AroneyS AroneyS requested a review from rhysnewell November 30, 2023 02:00
@AroneyS AroneyS merged commit a341fe4 into dev Dec 1, 2023
2 checks passed
@AroneyS AroneyS deleted the add-singlem-metapackage-downloading branch December 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants