Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support glob/regex patterns for self hosted runner labels configuration #377

Closed
kishaningithub opened this issue Nov 8, 2023 · 1 comment

Comments

@kishaningithub
Copy link
Contributor

kishaningithub commented Nov 8, 2023

Context

To add self hosted runners to the list i am doing something like

self-hosted-runner:
    labels:
      - private-runner-label1
      - private-runner-label2

but the problem the above way of configuration is not ideal if the label contains a dynamic elements, For example

self-hosted-runner:
    labels:
      - INSTANCE_TYPE=m6a.large # Yes this is a label :-)  

In the above the value of the INSTANCE_TYPE can be anything (t3.large, m2.large etc etc) and they are all valid github runner labels

Proposal

It would be great if this configuration can be made into a pattern like

self-hosted-runner:
    labels:
      - INSTANCE_TYPE=*  # The * matches everything  

This way i don't have to specify each and every label

@rhysd
Copy link
Owner

rhysd commented Feb 10, 2024

Closing as #378. Now glob pattern is supported.

@rhysd rhysd closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants